Hello USD - Part 7: Where my error messages at????

## should by python3? 
#!/usr/bin/python

## Python libraries
import subprocess, sys, os, argparse
## pixar usd library python scripts
from pxr import *
## validateMesh.py is file in same directory
from validateMesh import validateMesh
## validateMaterial.py is file in same directory
from validateMaterial import validateMaterial
## Note - these files are linked to later in post

def validateFile(file, verbose, errorData):
    ## UsdStage "owns the scenegraph and provides access to a composition." 
    ## https://github.com/PixarAnimationStudios/OpenUSD/blob/b53573ea2a6b29bc4a6b129f604bbb342c35df5c/pxr/usd/usd/stage.cpp#L866
    ## https://openusd.org/release/api/usd_page_front.html
    stage = Usd.Stage.Open(file)

    ## true until an error fires
    success = True

    ## https://github.com/PixarAnimationStudios/OpenUSD/blob/b53573ea2a6b29bc4a6b129f604bbb342c35df5c/pxr/usd/usd/primFlags.h#L576
    ## https://github.com/PixarAnimationStudios/OpenUSD/blob/b53573ea2a6b29bc4a6b129f604bbb342c35df5c/pxr/usd/usd/primFlags.h#L135
    ## Prims appear to have several booleans (flags) relating to their configuration / how deep they are, etc.  This "Usd_PrimFlagsPredicate" seems to gather them all together in a set and lets the summoner filter out non-relevant prims. (I suspect `Usd.PrimIsActive` etc are in fact bit masks as this really is a boolean and, not a logical and)
    predicate = Usd.TraverseInstanceProxies(Usd.PrimIsActive & Usd.PrimIsDefined & ~Usd.PrimIsAbstract)
    for prim in stage.Traverse(predicate):
        if prim.GetTypeName() == "Mesh":
            success = validateMesh(prim, verbose, errorData) and success
        if prim.GetTypeName() == "Material":
            success = validateMaterial(prim, verbose, errorData) and success
    return success

def runValidators(filename, verboseOutput, errorData):
    ## https://github.com/PixarAnimationStudios/OpenUSD/blob/b53573ea2a6b29bc4a6b129f604bbb342c35df5c/pxr/usd/usdUtils/complianceChecker.py#L912
    ## RIGHT HERE THE ABOVE IS THE THING TO READ.
    checker = UsdUtils.ComplianceChecker(arkit=True, 
            skipARKitRootLayerCheck=False, rootPackageOnly=False, 
            skipVariants=False, verbose=False) ## <-- Here is (a) verbose problem?
    # TODO: checker.DumpAllRules()?
    checker.CheckCompliance(filename)
    errors = checker.GetErrors()
    failedChecks = checker.GetFailedChecks()
    for rule in checker._rules:
        error = rule.__class__.__name__
        failures = rule.GetFailedChecks()
        if len(failures) > 0:
            errorData.append({ "code": "PXR_" + error })
            errors.append(error)

    usdCheckerResult = len(errors) == 0

    ## Where are the errors being printed? 

    ## Do the custom checks from the other files
    ## TODO: understand them
    mdlValidation = validateFile(filename, verboseOutput, errorData)

    success = usdCheckerResult and mdlValidation
    print("usdARKitChecker: " + ("[Pass]" if success else "[Fail]") + " " + filename)

def main(argumentList, outErrorList=None):
    ## Read in any arguments / options
    parser = argparse.ArgumentParser()
    parser.add_argument("--verbose", "-v", action='store_true', help="Verbose mode.")
    parser.add_argument('files', nargs='*')
    args=parser.parse_args(argumentList)

    verboseOutput = args.verbose

    ## Validation succeeds until it fails. 
    totalSuccess = True

    for filename in args.files:
        errorData = []
        ## filename: from the loop
        ## verboseOutput: From the flag
        ## errorData: Just defined. 
        runValidators(filename, verboseOutput, errorData)
        ## outErrorList: defined in function call as None by default
        ## When is it ever updated to not None? Is it just an optional out pipe? 
        if outErrorList is not None:
        	outErrorList.append({ "file": filename, "errors": errorData })
        # We're still good only if no new errors and no old errors
        totalSuccess = totalSuccess and len(errorData) == 0

    ## Program exits with no errors (code 0) if totalSuccess
    if totalSuccess:
        return 0
    else:
        return 1

if __name__ == '__main__':
    argumentList = sys.argv[1:]
    sys.exit(main(argumentList))

usdchecker --arkit ~/Developer/GitHub/USDHelloWorld/Part_06/multiball_20230709T222354.usda

#!/usr/bin/python3
## changed to python3

import subprocess, sys, os, argparse
from pxr import *
from validateMesh import validateMesh
from validateMaterial import validateMaterial

## No changes
def validateFile(file, verbose, errorData):
    stage = Usd.Stage.Open(file)
    success = True
    predicate = Usd.TraverseInstanceProxies(Usd.PrimIsActive & Usd.PrimIsDefined & ~Usd.PrimIsAbstract)
    for prim in stage.Traverse(predicate):
        if prim.GetTypeName() == "Mesh":
            success = validateMesh(prim, verbose, errorData) and success
        if prim.GetTypeName() == "Material":
            success = validateMaterial(prim, verbose, errorData) and success
    return success

## More verbose verbose mode
def runValidators(filename, verboseOutput, errorData):
    checker = UsdUtils.ComplianceChecker(arkit=True, 
            skipARKitRootLayerCheck=False, rootPackageOnly=False, 
            skipVariants=False, verbose=verboseOutput) #<- changed to pass verboseOutput through

    
    checker.CheckCompliance(filename)

    if verboseOutput:
        print("Rules Being Checked by usdchecker:")
        # checker.DumpAllRules() line failed with error: 
        # for ruleNum, rule in enumerate(GetBaseRules()):   
        # NameError: name 'GetBaseRules' is not defined
        for rule in checker._rules:
            print(rule)
        print("-----")

    errors = checker.GetErrors()
    failedChecks = checker.GetFailedChecks()
    warnings = checker.GetWarnings()
    
    if verboseOutput:
        for warning in warnings:
            print(warning)
        for error in errors:
            print(error)
        for failure in failedChecks:
            print(failure)
        print("-----")
    for rule in checker._rules:
        error = rule.__class__.__name__
        failures = rule.GetFailedChecks()
        if len(failures) > 0:
            errorData.append({ "code": "PXR_" + error })
            errors.append(error)
    if verboseOutput:
        print("Will be exported to outErrorList")
        print(errorData)
        print("----")

    usdCheckerResult = len(errors) == 0
    mdlValidation = validateFile(filename, verboseOutput, errorData)

    success = usdCheckerResult and mdlValidation
    print("usdARKitChecker: " + ("[Pass]" if success else "[Fail]") + " " + filename)

## No changes
def main(argumentList, outErrorList=None):
    parser = argparse.ArgumentParser()
    parser.add_argument("--verbose", "-v", action='store_true', help="Verbose mode.")
    parser.add_argument('files', nargs='*')
    args=parser.parse_args(argumentList)

    verboseOutput = args.verbose
    totalSuccess = True
    for filename in args.files:
        errorData = []
        runValidators(filename, verboseOutput, errorData)
        if outErrorList is not None:
            outErrorList.append({ "file": filename, "errors": errorData })
        totalSuccess = totalSuccess and len(errorData) == 0

    if totalSuccess:
        return 0
    else:
        return 1

if __name__ == '__main__':
    argumentList = sys.argv[1:]
    sys.exit(main(argumentList))

usdview ../Part_06/multiball_20230709T222354.usda
# File > Save flattened as... (choose USDC option)
usdchecker --arkit multiball_20230709T222354_flattened.usdc
> Success!
python3 usdARKitChecker_revised.py multiball_20230709T222354_flattened.usdc
> usdARKitChecker: [Pass] multiball_20230709T222354_flattened.usdc

# note just the ONE input file name, the root scene file
usdcat -o output_test_2.usdc --flatten ../Part_06/multiball_20230709T222354.usda
python3 usdARKitChecker_revised.py output_test_2.usdc
> usdARKitChecker: [Pass] output_test_2.usdc

#!/bin/sh

# Usage: give the script the name of the root file and
# the root file only, not the full list. 
# can be replaced with 
# `usdcat -o $OUTPUT_NAME --flatten $INPUT_ROOT_FILE``

#PATH_TO_USDCAT="somepath"
REMOVE_TMP_FLAG=false
TMP_FILE_NAME="smash_tmp.usda"
OUTPUT_NAME="smash_output.usdc"

# using $@ (all args) is iffy here since really
# should be passing _one_ file name after all.
usdcat --flatten $@ > $TMP_FILE_NAME
usdcat -o $OUTPUT_NAME $TMP_FILE_NAME
if $REMOVE_TMP_FLAG; then
    rm $TMP_FILE_NAME
fi